Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DAFA59480 for ; Thu, 5 Jan 2012 23:02:04 +0000 (UTC) Received: (qmail 44592 invoked by uid 500); 5 Jan 2012 23:02:03 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 44324 invoked by uid 500); 5 Jan 2012 23:02:03 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 44156 invoked by uid 99); 5 Jan 2012 23:02:02 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jan 2012 23:02:02 +0000 X-ASF-Spam-Status: No, hits=-2001.6 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jan 2012 23:02:00 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id D631713AE66 for ; Thu, 5 Jan 2012 23:01:39 +0000 (UTC) Date: Thu, 5 Jan 2012 23:01:39 +0000 (UTC) From: "Brandon Williams (Commented) (JIRA)" To: commits@cassandra.apache.org Message-ID: <950381964.12137.1325804499878.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <734590954.50297.1325127934775.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (CASSANDRA-3681) Multiple threads can attempt hint handoff to the same target MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CASSANDRA-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180919#comment-13180919 ] Brandon Williams commented on CASSANDRA-3681: --------------------------------------------- +1 > Multiple threads can attempt hint handoff to the same target > ------------------------------------------------------------ > > Key: CASSANDRA-3681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3681 > Project: Cassandra > Issue Type: Bug > Components: Core > Affects Versions: 1.0.0 > Reporter: Jonathan Ellis > Assignee: Jonathan Ellis > Priority: Minor > Labels: hintedhandoff > Fix For: 1.0.7 > > Attachments: 3681-v3.txt, 3681.txt, 3681v2.txt > > > HintedHandOffManager attempts to prevent multiple threads sending hints to the same target with the queuedDeliveries set, but the code is buggy. If two handoffs *do* occur concurrently, the second thread can use an arbitrarily large amount of memory skipping tombstones when it starts paging from the beginning of the hint row, looking for the first live hint. (This is not a problem with a single thread, since it always pages starting with the last-seen hint column name, effectively skipping the tombstones. Then it compacts when it's done.) > Technically this bug is present in all older Cassandra releases, but it only causes problems in 1.0.x since the hint rows tend to be much larger (since there is one hint per write containing the entire mutation, instead of just one per row consisting of just the key). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira