cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbel...@apache.org
Subject [12/50] [abbrv] git commit: avoid logging (harmless) exception when GC takes < 1ms patch by jbellis; reviewed by brandonwilliams for CASSANDRA-3656
Date Thu, 05 Jan 2012 20:00:29 GMT
avoid logging (harmless) exception when GC takes < 1ms
patch by jbellis; reviewed by brandonwilliams for CASSANDRA-3656

git-svn-id: https://svn.apache.org/repos/asf/cassandra/branches/cassandra-0.8@1222440 13f79535-47bb-0310-9956-ffa450edef68


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/8d6b6f65
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/8d6b6f65
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/8d6b6f65

Branch: refs/heads/trunk
Commit: 8d6b6f65795088ba906115e1267f6be2a668d9dc
Parents: f198582
Author: Jonathan Ellis <jbellis@apache.org>
Authored: Thu Dec 22 20:42:23 2011 +0000
Committer: Jonathan Ellis <jbellis@apache.org>
Committed: Thu Dec 22 20:42:23 2011 +0000

----------------------------------------------------------------------
 CHANGES.txt                                        |    1 +
 .../org/apache/cassandra/service/GCInspector.java  |    3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/8d6b6f65/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 803e716..01159aa 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -2,6 +2,7 @@
  * prevent new nodes from thinking down nodes are up forever (CASSANDRA-3626)
 
 0.8.9
+ * avoid logging (harmless) exception when GC takes < 1ms (CASSANDRA-3656)
  * remove invalid assertion that table was opened before dropping it
    (CASSANDRA-3580)
  * range and index scans now only send requests to enough replicas to

http://git-wip-us.apache.org/repos/asf/cassandra/blob/8d6b6f65/src/java/org/apache/cassandra/service/GCInspector.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/service/GCInspector.java b/src/java/org/apache/cassandra/service/GCInspector.java
index e4e7a8e..2320f48 100644
--- a/src/java/org/apache/cassandra/service/GCInspector.java
+++ b/src/java/org/apache/cassandra/service/GCInspector.java
@@ -98,8 +98,7 @@ public class GCInspector
             if (previousTotal.equals(total))
                 continue;
             gctimes.put(gc.getName(), total);
-            Long duration = total - previousTotal;
-            assert duration > 0;
+            Long duration = total - previousTotal; // may be zero for a really fast collection
 
             Long previousCount = gccounts.get(gc.getName());
             Long count = gc.getCollectionCount();


Mime
View raw message