cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Schuller (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-3729) support counter debug mode on thrift interface
Date Thu, 12 Jan 2012 08:37:39 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184820#comment-13184820
] 

Peter Schuller commented on CASSANDRA-3729:
-------------------------------------------

Just to be clear, it's a per-client setting whether or not the counters are returned un-encoded
or not. So one of the nice features is that you can take a running Cassandra instance (e.g.
in production) and connect your client to it, enable debug mode *for your connection*, and
inspect.

Before this I was doing sstable2json to filter out the key I wanted so I could iterate quickly,
and then continuously rebuilding Cassandra with increasing amounts of debug loggings enabled.
Doable, but it was very nice to have this ;)

A JMX setting sounds like it would be global. The reason to put it at the thrift level to
begin with is that it's per-connection.

How about this: Suppose we create a developer-only service that extends the public service?
Everything built using the public interface would not even be aware additional calls exist.
Hmm. Or just have a separate thrift service with debug/dev-only calls, with e.g., a get_counter_context()
or something like that.

I dunno. I understand the reluctance to dirty the public interface, yet this was so very useful.

                
> support counter debug mode on thrift interface
> ----------------------------------------------
>
>                 Key: CASSANDRA-3729
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3729
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Peter Schuller
>            Assignee: Peter Schuller
>            Priority: Minor
>         Attachments: trunk-3729.txt
>
>
> Attaching a patch against trunk to add a counter debug mode on the thrift interface,
allowing clients to decode and inspect counter contexts. This is all Stu's code, except that
I generated the thrift stuff so any mistakes there are mine.
> This was extremely useful internally on an 0.8. The patch is not yet tested on trunk,
but if you think this can go in I will spend effort to test it soonish.
> It's not very invasive (other than the generated thrift code), so it feels okay to have
it if we maybe document that it is not a supported interface (clearly in the thrift spec).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message