cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-3703) log Compaction Active tasks in StatusLogger instead of n/a
Date Thu, 26 Jan 2012 09:49:40 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193700#comment-13193700
] 

Sylvain Lebresne commented on CASSANDRA-3703:
---------------------------------------------

Yeah but in CompactionManager, executor refers only to the compactionExecutor. And getActiveCount()
is a method from ThreadPoolExecutor, so it'll reference the tasks on the compaction executor
only. Basically what I'm saying is that we should have:
{noformat}
public int getActiveTasks()
{
    return executor.getActiveCount() + validationExecutor.getActiveCount();
}
{noformat}

That being said, it could make some sense to log CM.getActiveCompactions() instead (which
does uses CE.compactions and thus relate to both compaction and validation). The difference
being that getActiveCompactions will return tasks actively compacting (by opposition to including
those waiting on the compaction lock).
                
> log Compaction Active tasks in StatusLogger instead of n/a
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-3703
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3703
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jackson Chung
>            Assignee: Jonathan Ellis
>            Priority: Minor
>              Labels: compaction
>             Fix For: 1.0.8
>
>         Attachments: 3703.txt
>
>
> currently StatusLogger log:
> {noformat}
> logger.info(String.format("%-25s%10s%10s",
>                                   "CompactionManager", "n/a", CompactionManager.instance.getPendingTasks()));
> {noformat}
> It'd be great if it could actually log the number of active tasks being processed. Without
looking into the code, I thought there was no compaction running when reading the log.
> {code: title=CompactionManager.java}
>     public int getActiveCompactions()
>     {
>         return CompactionExecutor.compactions.size();
>     }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message