cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Evans (Issue Comment Edited) (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (CASSANDRA-3665) [patch] allow for clientutil.jar to be used without the base cassandra.jar for client applications
Date Thu, 26 Jan 2012 22:25:49 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194225#comment-13194225
] 

Eric Evans edited comment on CASSANDRA-3665 at 1/26/12 10:24 PM:
-----------------------------------------------------------------

bq. UUIDGen.makeType1UUIDFromHost

Auh, there it is, a dependency on {{FBUtilities.hash()}}.

OK, since (sadly )smoke-testing seems to be the best way to go about this, the attached patches
include a test that's meant to exercise the code in clientutil (including {{UUIDGen.makeType1UUIDFromHost}}),
in order to spot the exceptions caused by unintentional dependencies.

And, instead of adding FBUtils to the jar (and the couple of dozen transitive dependencies),
I added a hash function to {{UUIDGen}} (based on the one from FBUtils).

_Edit: Dave, could you test this and see if it solves your issue?_
                
      was (Author: urandom):
    bq. UUIDGen.makeType1UUIDFromHost

Auh, there it is, a dependency on {{FBUtilities.hash()}}.

OK, since (sadly )smoke-testing seems to be the best way to go about this, the attached patches
include a test that's meant to exercise the code in clientutil (including {{UUIDGen.makeType1UUIDFromHost}}),
in order to spot the exceptions caused by unintentional dependencies.

And, instead of adding FBUtils to the jar (and the couple of dozen transitive dependencies),
I added a hash function to {{UUIDGen}} (based on the one from FBUtils).
                  
> [patch] allow for clientutil.jar to be used without the base cassandra.jar for client
applications
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3665
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3665
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: 1.0.6
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>         Attachments: fix_client_util_jar.diff, v1-0001-CASSANDRA-3665-test-to-expose-missing-dependencies.txt,
v1-0002-eliminate-dependency-on-FBUtilities.txt
>
>
> clientutil.jar can't be run from a client by itself without the presence of cassandra.jar
which seems wrong. Added needed classes to run by itself.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message