Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Sun, 18 Dec 2011 16:28:31 +0000 (UTC)
From: "Pavel Yaskevich (Updated) (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: 
 <904929796.24371.1324225711702.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1297670359.6831.1316788826957.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (CASSANDRA-3250) fsync the directory after new
 sstable or commit log segment are created
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CASSANDRA-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Yaskevich updated CASSANDRA-3250:
---------------------------------------

    Attachment: CASSANDRA-3250-v3.patch

Ok, v3 O_DIRECTORY changed to O_RDONLY and checks for linux are removed from CLibrary.

O_DIRECTORY just causes open to fail if given path is not a directory, so it seems we can live without it :)
                
> fsync the directory after new sstable or commit log segment are created
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-3250
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3250
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Zhu Han
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>             Fix For: 1.0.7
>
>         Attachments: CASSANDRA-3250-v2.patch, CASSANDRA-3250-v3.patch, CASSANDRA-3250.patch
>
>
> The mannual of fsync said:
> bq.   Calling  fsync()  does  not  necessarily  ensure  that  the entry in the directory containing the file has also reached disk.  For that an explicit fsync() on a file descriptor for the directory is also needed.
> At least on ext4, syncing the directory is a must to have step, as described by [1]. Otherwise, the new sstables or commit logs could be missed after crash even if itself is synced. 
> Unfortunately, JVM does not provide an approach to sync the directory...
> [1] http://www.linuxfoundation.org/news-media/blogs/browse/2009/03/don%E2%80%99t-fear-fsync

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira