cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbel...@apache.org
Subject svn commit: r1222440 - in /cassandra/branches/cassandra-0.8: CHANGES.txt src/java/org/apache/cassandra/service/GCInspector.java
Date Thu, 22 Dec 2011 20:42:23 GMT
Author: jbellis
Date: Thu Dec 22 20:42:23 2011
New Revision: 1222440

URL: http://svn.apache.org/viewvc?rev=1222440&view=rev
Log:
avoid logging (harmless) exception when GC takes < 1ms
patch by jbellis; reviewed by brandonwilliams for CASSANDRA-3656

Modified:
    cassandra/branches/cassandra-0.8/CHANGES.txt
    cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/GCInspector.java

Modified: cassandra/branches/cassandra-0.8/CHANGES.txt
URL: http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/CHANGES.txt?rev=1222440&r1=1222439&r2=1222440&view=diff
==============================================================================
--- cassandra/branches/cassandra-0.8/CHANGES.txt (original)
+++ cassandra/branches/cassandra-0.8/CHANGES.txt Thu Dec 22 20:42:23 2011
@@ -2,6 +2,7 @@
  * prevent new nodes from thinking down nodes are up forever (CASSANDRA-3626)
 
 0.8.9
+ * avoid logging (harmless) exception when GC takes < 1ms (CASSANDRA-3656)
  * remove invalid assertion that table was opened before dropping it
    (CASSANDRA-3580)
  * range and index scans now only send requests to enough replicas to

Modified: cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/GCInspector.java
URL: http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/GCInspector.java?rev=1222440&r1=1222439&r2=1222440&view=diff
==============================================================================
--- cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/GCInspector.java
(original)
+++ cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/GCInspector.java
Thu Dec 22 20:42:23 2011
@@ -98,8 +98,7 @@ public class GCInspector
             if (previousTotal.equals(total))
                 continue;
             gctimes.put(gc.getName(), total);
-            Long duration = total - previousTotal;
-            assert duration > 0;
+            Long duration = total - previousTotal; // may be zero for a really fast collection
 
             Long previousCount = gccounts.get(gc.getName());
             Long count = gc.getCollectionCount();



Mime
View raw message