cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-3649) Code style changes, aka The Big Reformat
Date Tue, 20 Dec 2011 12:53:31 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173160#comment-13173160
] 

Sylvain Lebresne commented on CASSANDRA-3649:
---------------------------------------------

I'm +1 on the remove of underscores in private variables. We don't do that anymore since a
long time and this will bring consistency to the code base. I would also like replacing tabs
by spaces in the few places where tabs are used (again consistency) and remove all end-of-line
spaces (but that's to please my OCD, I'll live if we don't do it).

But moving from brace-on-newline, not really fond of the idea. The code base is actually pretty
consistent in its use of brace-on-newline, so moving from it won't add any consistency, it
will just change the style. Ultimately style is a very subjective thing; I, for one, prefer
brace-on-newlines. And I understand that the oracle conventions is to not have braces on new
lines, and I would be fine with that argument alone if we were discussing the style of a new
project, but changing this now means that no patch from before the refactor will ever apply,
including everything that will be committed to some older version and merged up and every
patches attached to JIRA at the time of the refactor. The other refactorings suggested above
don't even come close to that because they are just about making minor parts of the code base
more consistent with the vast majority of it. So following the "definitions" from http://www.apache.org/foundation/voting.html,
I'm -0.9 for moving from brace-on-newlines.
                
> Code style changes, aka The Big Reformat
> ----------------------------------------
>
>                 Key: CASSANDRA-3649
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3649
>             Project: Cassandra
>          Issue Type: Wish
>          Components: Core
>            Reporter: Brandon Williams
>             Fix For: 1.2
>
>
> With a new major release coming soon and not having a ton of huge pending patches that
have prevented us from doing this in the past, post-freeze looks like a good time to finally
do this.  Mostly this will include the removal of underscores in private variables, and no
more brace-on-newline policy.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message