cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-3559) CFMetaData conversions to Thrift/Avro should probably be inverse one of the other
Date Tue, 20 Dec 2011 16:50:31 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173300#comment-13173300
] 

Sylvain Lebresne commented on CASSANDRA-3559:
---------------------------------------------

True. I'm fine waiting to see if it makes it for 1.1 and close that one if so.
                
> CFMetaData conversions to Thrift/Avro should probably be inverse one of the other
> ---------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3559
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3559
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>              Labels: avro, thrift
>             Fix For: 1.1
>
>         Attachments: 3559.patch
>
>
> In other word, it would probably be a idea to have:
> {noformat}
>   cfm == CFMetadata.fromThrift(cfm.toThrift())
>   cfm == CFMetadata.fromAvro(cfm.toAvro())
> {noformat}
> In particular, we could have unit tests to check that, which would avoid things like
CASSANDRA-3558.
> It is not the case today for thrift because of the keyAlias. For some reason, if the
keyAlias is not set, we return with toThrift() the default alias. I don't think this serves
any purpose though.
> The goal of this ticket is to both fix that (unless there is a compelling reason not
to) and add unit tests for this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message