cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (Resolved) (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CASSANDRA-3658) Fix smallish problems find by FindBugs
Date Thu, 22 Dec 2011 21:57:30 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-3658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sylvain Lebresne resolved CASSANDRA-3658.
-----------------------------------------

    Resolution: Fixed
      Reviewer: jbellis
      Assignee: Sylvain Lebresne

I'm good with keeping the assert. Committed all except 09. Thanks
                
> Fix smallish problems find by FindBugs
> --------------------------------------
>
>                 Key: CASSANDRA-3658
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3658
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>              Labels: fingbugs
>             Fix For: 1.1
>
>         Attachments: 0001-Respect-Future-semantic.patch, 0002-Avoid-race-when-reloading-snitch-file.patch,
0003-use-static-inner-class-when-possible.patch, 0004-Remove-dead-code.patch, 0005-Protect-against-signed-byte-extension.patch,
0006-Add-hashCode-method-when-equals-is-overriden.patch, 0007-Inverse-argument-of-compare-instead-of-negating-to-a.patch,
0008-stop-pretending-Token-is-Serializable-LocalToken-is-.patch, 0009-remove-useless-assert-that-is-always-true.patch,
0010-Add-equals-and-hashCode-to-Expiring-column.patch
>
>
> I've just run (the newly released) FindBugs 2 out of curiosity. Attaching a number of
patches related to issue raised by it. There is nothing major at all so all patches are against
trunk.
> I've tried keep each issue to it's own patch with a self describing title. It far from
covers all FindBugs alerts, but it's a picky tool so I've tried to address only what felt
at least vaguely useful. Those are still mostly nits (only patch 2 is probably an actual bug).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message