cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-2407) Compaction thread should try to empty a bucket before moving on
Date Fri, 18 Nov 2011 16:18:51 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152943#comment-13152943
] 

Sylvain Lebresne commented on CASSANDRA-2407:
---------------------------------------------

Two very small nitpicks while I'm at it:
* Do we really need this ImmutableSet.copy(sstables) in DT.nonCompactingSSTables() ? Feels
far-fectched that difference() would modify one of it's argument.
* In STCS.getNextBrackgroundTask, we could use Collections.min() rather than Collections.sort().

But otherwise lgtm, +1 (with or whithout the nits above)

                
> Compaction thread should try to empty a bucket before moving on
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-2407
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2407
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Stu Hood
>            Assignee: Jonathan Ellis
>            Priority: Minor
>              Labels: compaction
>             Fix For: 1.1
>
>         Attachments: 2407-v2.txt, 2407-v3.txt, 2407-v4.txt, 2407.txt
>
>
> As suggested by Aaron Morton [(1)|https://issues.apache.org/jira/browse/CASSANDRA-2191?focusedCommentId=13010077&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13010077],
a compaction thread should attempt to empty a bucket before moving on to a larger bucket.
This would change the submitMinorIfNeeded {{for}} loop into a while loop that regenerated
the buckets and started from the bottom after each successful compaction.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message