cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-3474) SSTableMetadata deserialization works but looks broken
Date Wed, 09 Nov 2011 15:31:51 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147101#comment-13147101
] 

Sylvain Lebresne commented on CASSANDRA-3474:
---------------------------------------------

The patch needs rebasing but lgtm otherwise.
                
> SSTableMetadata deserialization works but looks broken
> ------------------------------------------------------
>
>                 Key: CASSANDRA-3474
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3474
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.0.3
>
>         Attachments: 3474.txt
>
>
> This is confusing:
> {code}
> .               if (!descriptor.usesHistogramAndReplayPositionStatsFile)
>                   return deserialize(dis); // deserializes histogram
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message