cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-3472) Actually uses efficient cross DC writes
Date Tue, 08 Nov 2011 10:38:51 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sylvain Lebresne updated CASSANDRA-3472:
----------------------------------------

    Attachment: 3472.patch

Attached patch is against 0.8
                
> Actually uses efficient cross DC writes
> ---------------------------------------
>
>                 Key: CASSANDRA-3472
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3472
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.8.8, 1.0.3
>
>         Attachments: 3472.patch
>
>
> CASSANDRA-2138 introduced the following code:
> {noformat}
> if (dataCenter.equals(localDataCenter) || StorageService.instance.useEfficientCrossDCWrites())
> {
>     // direct writes to local DC or old Cassadra versions
>     for (InetAddress destination : messages.getValue())
>         MessagingService.instance().sendRR(message, destination, handler);
> }
> else
> {
>     // Non-local DC. First endpoint in list is the destination for this group
> {noformat}
> A 'not' is missing on that useEfficientCrossDCWrites call (which does return true for
any version >= 0.7.1).
> A simple fix would be to add the missing !, but as said a comment, all this code should
have been removed in 0.8 since it was detecting nodes before 0.7.1, but direct upgrade from
pre-0.7.1 to 0.8+ is not supported. So let's just completely remove that code now.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message