cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-1740) Nodetool commands to query and stop compaction, repair, cleanup and scrub
Date Wed, 16 Nov 2011 15:08:52 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151251#comment-13151251
] 

Jonathan Ellis commented on CASSANDRA-1740:
-------------------------------------------

I'm not a fan of the instanceof UIE in the default exception handler.  Feels spaghetti-ish
to me.

What about checking for UIE in the compactionexecutor afterExecute?  That would address the
DRY problem without violating encapsulation so badly.

Nit: would prefer mutable fields to be private and exposed via getter if necessary, e.g. would
use Holder.isStopped() here.
                
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1740
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Chip Salzenberg
>            Assignee: Vijay
>            Priority: Minor
>              Labels: compaction
>             Fix For: 1.0.4
>
>         Attachments: 0001-Patch-to-Stop-compactions-v2.patch, 0001-Patch-to-Stop-compactions.patch,
CASSANDRA-1740.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to stop and
restart the entire Cassandra server.  Please provide nodetool commands to query whether such
things are running, and stop them if they are.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message