Return-Path: 
 <commits-return-43229-apmail-cassandra-commits-archive=cassandra.apache.org@cassandra.apache.org>
X-Original-To: apmail-cassandra-commits-archive@www.apache.org
Delivered-To: apmail-cassandra-commits-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id EA2707AB8
	for <apmail-cassandra-commits-archive@www.apache.org>;
 Sat, 29 Oct 2011 00:59:55 +0000 (UTC)
Received: (qmail 64399 invoked by uid 500); 29 Oct 2011 00:59:55 -0000
Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org
Received: (qmail 64376 invoked by uid 500); 29 Oct 2011 00:59:55 -0000
Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@cassandra.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@cassandra.apache.org>
List-Post: <mailto:commits@cassandra.apache.org>
List-Id: <commits.cassandra.apache.org>
Reply-To: dev@cassandra.apache.org
Delivered-To: mailing list commits@cassandra.apache.org
Received: (qmail 64368 invoked by uid 99); 29 Oct 2011 00:59:55 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Oct 2011 00:59:55 +0000
X-ASF-Spam-Status: No, hits=-2000.5 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Oct 2011 00:59:53 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 3EC9A323A41
	for <commits@cassandra.apache.org>; Sat, 29 Oct 2011 00:59:32 +0000 (UTC)
Date: Sat, 29 Oct 2011 00:59:32 +0000 (UTC)
From: "Pavel Yaskevich (Commented) (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: 
 <1268380710.35234.1319849972258.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <647030627.35791.1316197509414.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (CASSANDRA-3220) add describe_ring to cli
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/CASSANDRA-3220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139032#comment-13139032 ] 

Pavel Yaskevich commented on CASSANDRA-3220:
--------------------------------------------

I think that this should handle empty <keyspace> argument in the same way `describe` does. 
If you want to show exception message instead of "null" you should catch InvalidRequestionException and TException inside of your method.
According to "datacenter=null" problem, it was already fixed by CASSANDRA-3403.

Also you have a doubled "," in the error message, it should be "String.format("Keyspace with name '%s' wasn't found, please, authorize to one of the keyspaces first.", entityName)". 

                
> add describe_ring to cli
> ------------------------
>
>                 Key: CASSANDRA-3220
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3220
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Jackson Chung
>            Assignee: Jackson Chung
>            Priority: Minor
>             Fix For: 1.0.2
>
>         Attachments: patch3220.diff
>
>
> Lately I have found the describe_ring feature was needed to debug/analyze issue, but the cli does not have this available.
> So just in case it is useful, please see the attached patch.
> here is the sample output:
> {noformat}
> [default@unknown] help;
> ...
> ...
> decr                    Decrements a counter column.
> describe ring           Describe the token range information.
> describe cluster        Describe the cluster configuration.
> ...
> ...
> [default@unknown] help describe ring;
> describe ring <keyspace>;
> Describes the token range settings for the named keyspace.
> Required Parameters:
> - keyspace: Name of the keyspace to describe the token range.
> Examples:
> describe ring <keyspace>; - Describes the token range settings for the named keyspace.
> [default@unknown] describe ring Keyspace3;
> TokenRange: 
>         TokenRange(start_token:9739248273232290250409572410247679660, end_token:9739248273232290250409572410247679660, endpoints:[192.168.0.125], rpc_endpoints:[192.168.0.125], endpoint_details:[EndpointDetails(host:192.168.0.125, port:9160, datacenter:168)])
> [default@unknown] describe ring fooks;
> Keyspace with name 'fooks' wasn't found, , please, authorize to one of the keyspaces first.
> [default@unknown] describe ring;
> Syntax error at position 13: mismatched input ';' expecting set null
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira