cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yang Yang (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CASSANDRA-3390) ReadResponseSerializer.serializedSize() calculation is wrong
Date Thu, 20 Oct 2011 19:46:10 GMT
ReadResponseSerializer.serializedSize() calculation is wrong
------------------------------------------------------------

                 Key: CASSANDRA-3390
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3390
             Project: Cassandra
          Issue Type: Bug
            Reporter: Yang Yang
         Attachments: 3390.patch

in ReadResponse.java


the following code

    public long serializedSize(ReadResponse response, int version)
    {
        int size = DBConstants.intSize;
        size += (response.isDigestQuery() ? response.digest() : ByteBufferUtil.EMPTY_BYTE_BUFFER).remaining();
        size += DBConstants.boolSize;
        if (response.isDigestQuery())
            size += response.digest().remaining();
        else
            size += Row.serializer().serializedSize(response.row(), version);
        return size;
    }


adds the digest size 2 times

this triggers assertion error in at least ReadVerbHandler




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message