cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-3299) clientutil depends on FBUtilities (bad)
Date Mon, 10 Oct 2011 16:53:30 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124285#comment-13124285
] 

Hudson commented on CASSANDRA-3299:
-----------------------------------

Integrated in Cassandra #1150 (See [https://builds.apache.org/job/Cassandra/1150/])
    move FBUtils methods for bytes<->hex to separate class

Patch by eevans; reviewed by jbellis for CASSANDRA-3299

eevans : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1181018
Files : 
* /cassandra/trunk/build.xml
* /cassandra/trunk/drivers/java/test/org/apache/cassandra/cql/JdbcDriverTest.java
* /cassandra/trunk/drivers/java/test/org/apache/cassandra/cql/jdbc/PreparedStatementTest.java
* /cassandra/trunk/examples/simple_authentication/src/org/apache/cassandra/auth/SimpleAuthenticator.java
* /cassandra/trunk/src/java/org/apache/cassandra/auth/Resources.java
* /cassandra/trunk/src/java/org/apache/cassandra/db/marshal/BytesType.java
* /cassandra/trunk/src/java/org/apache/cassandra/dht/AbstractByteOrderedPartitioner.java
* /cassandra/trunk/src/java/org/apache/cassandra/dht/BytesToken.java
* /cassandra/trunk/src/java/org/apache/cassandra/hadoop/ConfigHelper.java
* /cassandra/trunk/src/java/org/apache/cassandra/utils/ByteBufferUtil.java
* /cassandra/trunk/src/java/org/apache/cassandra/utils/FBUtilities.java
* /cassandra/trunk/src/java/org/apache/cassandra/utils/Hex.java
* /cassandra/trunk/src/java/org/apache/cassandra/utils/MerkleTree.java
* /cassandra/trunk/test/unit/org/apache/cassandra/db/marshal/RoundTripTest.java
* /cassandra/trunk/test/unit/org/apache/cassandra/utils/FBUtilitiesTest.java
* /cassandra/trunk/test/unit/org/apache/cassandra/utils/HexTest.java
* /cassandra/trunk/test/unit/org/apache/cassandra/utils/MerkleTreeTest.java

                
> clientutil depends on FBUtilities (bad)
> ---------------------------------------
>
>                 Key: CASSANDRA-3299
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3299
>             Project: Cassandra
>          Issue Type: Bug
>          Components: API, Drivers
>    Affects Versions: 1.0.0
>            Reporter: Eric Evans
>            Assignee: Eric Evans
>              Labels: cql
>             Fix For: 1.0.1
>
>         Attachments: v1-0001-CASSANDRA-3299-move-FBUtils-methods-for-bytes-hex-to-s.txt
>
>
> clientutils' (indirect )dependency on FBUtilities (needed for tests) would result in
huge numbers of classes being pulled in transitively.
> The attached patch moves the {{bytesToHex}} and {{hexToBytes}} methods into a new class
({{o.a.c.utils.Hex}}), which has no external dependencies.
> This should be pretty safe, but I've marked it fixfor-1.0.1 since we're so close to release,
and because the JDBC driver can embed a snapshot jar in the meantime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message