cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-3299) clientutil depends on FBUtilities (bad)
Date Mon, 03 Oct 2011 22:00:36 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119665#comment-13119665
] 

Jonathan Ellis commented on CASSANDRA-3299:
-------------------------------------------

Nit: can we just name the methods Hex.toBytes and Hex.toString?

+1 otherwise
                
> clientutil depends on FBUtilities (bad)
> ---------------------------------------
>
>                 Key: CASSANDRA-3299
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3299
>             Project: Cassandra
>          Issue Type: Bug
>          Components: API, Drivers
>    Affects Versions: 1.0.0
>            Reporter: Eric Evans
>            Assignee: Eric Evans
>              Labels: cql
>             Fix For: 1.0.1
>
>         Attachments: v1-0001-CASSANDRA-3299-move-FBUtils-methods-for-bytes-hex-to-s.txt
>
>
> clientutils' (indirect )dependency on FBUtilities (needed for tests) would result in
huge numbers of classes being pulled in transitively.
> The attached patch moves the {{bytesToHex}} and {{hexToBytes}} methods into a new class
({{o.a.c.utils.Hex}}), which has no external dependencies.
> This should be pretty safe, but I've marked it fixfor-1.0.1 since we're so close to release,
and because the JDBC driver can embed a snapshot jar in the meantime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message