Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Thu, 8 Sep 2011 19:36:10 +0000 (UTC)
From: "Pavel Yaskevich (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: 
 <270069402.4567.1315510570879.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <2033768149.4342.1310427419807.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Issue Comment Edited] (CASSANDRA-2882) describe_ring should
 include datacenter/topology information
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100622#comment-13100622 ] 

Pavel Yaskevich edited comment on CASSANDRA-2882 at 9/8/11 7:35 PM:
--------------------------------------------------------------------

Few notes:
 - I don't think that we need to add EndpointDetails without information about datacenter or port, having (-1, null) there is misleading.
 - you can change Vector to ArrayList because you don't use any vector specific features such as capacity planing and auto-resize etc.
 - Please instead of {noformat}tr.endpoint_details = epDetails;{noformat} do {noformat}new TokenRange(tf.toString(range.left), tf.toString(range.right), endpoints).setEndpoint_details(epDetails);{noformat} because that way thrift will mark that field as set.

Looks good otherwise.

      was (Author: xedin):
    Few notes:
 - I don't think that we need to add EndpointDetails without information about datacenter or port, having (-1, null) there is misleading. 
 - Please instead of {noformat}tr.endpoint_details = epDetails;{noformat} do {noformat}new TokenRange(tf.toString(range.left), tf.toString(range.right), endpoints).setEndpoint_details(epDetails);{noformat} because that way thrift will mark that field as set.

Looks good otherwise.
  
> describe_ring should include datacenter/topology information
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-2882
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2882
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: API, Core
>            Reporter: Mark Guzman
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>              Labels: lhf
>             Fix For: 1.1
>
>         Attachments: 0001-CASSANDRA-2882-patch-w-o-generated-files.patch, 0001-CASSANDRA-2882-rebased.patch, 0001-adding-an-additional-parameter-to-the-TokenRange-res.patch, 0001-final-cleaned-up-2882-changes.patch
>
>
> describe_ring is great for getting a list of nodes in the cluster, but it doesn't provide any information about the network topology which prevents it's use in a multi-dc setup. It would be nice if we added another list to the TokenRange object containing the DC information. 
> Optimally I could have ask any Cassandra node for this information and on the client-side prefer local nodes but be able to fail to remote nodes without requiring another lookup.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira