Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Mon, 26 Sep 2011 16:51:26 +0000 (UTC)
From: "Jonathan Ellis (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: 
 <1813133958.13189.1317055886565.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <143453573.13044.1317053607066.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (CASSANDRA-3260) MergeIterator assertion on
 sources != empty can be thrown
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114775#comment-13114775 ] 

Jonathan Ellis commented on CASSANDRA-3260:
-------------------------------------------

Should also then change the next line from

        if (sources.size() == 1)

to

        if (sources.size() <= 1)

+1 w/ that

> MergeIterator assertion on sources != empty can be thrown
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-3260
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3260
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Trivial
>             Fix For: 1.0.0
>
>         Attachments: 3260.patch
>
>
> MergeIterator.get assert that it don't get an empty list of sources. This seems to at least not be the case in the unit test for some of tests (this don't make any test fail however, but there is a few stack trace thrown). I think it's pretty unnatural to "fail" on an empty list of sources and would force every caller to first take the empty case into account, so I propose to just remove that assertion.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira