Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Sat, 17 Sep 2011 00:33:08 +0000 (UTC)
From: "Yang Yang (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: 
 <1499165455.37451.1316219588900.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Created] (CASSANDRA-3223) probably don't need to do full
 copy to row cache after un-mmap() change
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

probably don't need to do full copy to row cache after un-mmap() change
-----------------------------------------------------------------------

                 Key: CASSANDRA-3223
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3223
             Project: Cassandra
          Issue Type: Bug
            Reporter: Yang Yang
            Priority: Minor


3179  changes from directly using the bytebuffer from mmap(), to copying that buffer,

CFS.cacheRow() https://github.com/apache/cassandra/blob/cassandra-1.0.0/src/java/org/apache/cassandra/db/ColumnFamilyStore.java   line 1126
says it makes a deep copy exactly to prevent issues from unmmap().

maybe this deep copy is not needed now given 3179


if so, maybe slightly better performance in both speed and memory

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira