cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-3262) SimpleSnitch.compareEndpoints doesn't respect the intent of the snitch
Date Wed, 28 Sep 2011 05:15:45 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116163#comment-13116163
] 

Hudson commented on CASSANDRA-3262:
-----------------------------------

Integrated in Cassandra-0.8 #346 (See [https://builds.apache.org/job/Cassandra-0.8/346/])
    Keep SimpleSnitch proximity ordering unchanged from what the Strategy generates, as intended
patch by slebresne; reviewed by jbellis for CASSANDRA-3262

jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176712
Files : 
* /cassandra/branches/cassandra-0.8/CHANGES.txt
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/locator/AbstractEndpointSnitch.java
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/locator/AbstractNetworkTopologySnitch.java
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/locator/DynamicEndpointSnitch.java
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/locator/SimpleSnitch.java

                
> SimpleSnitch.compareEndpoints doesn't respect the intent of the snitch
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-3262
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3262
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.8.6
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.8.7, 1.0.0
>
>         Attachments: 3262.patch
>
>
> SimpleSnitch is supposed to not sort the input addresses, thus respecting the order of
the partitioner. However, it's compareEndpoints instead uses IP addresses comparison. Note
that this matter when the dynamicSnitch fall back to the wrapped snitch since it uses the
compareEndpoint method then.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message