cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yang Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-3223) probably don't need to do full copy to row cache after un-mmap() change
Date Sat, 17 Sep 2011 04:50:13 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107020#comment-13107020
] 

Yang Yang commented on CASSANDRA-3223:
--------------------------------------

sure



> probably don't need to do full copy to row cache after un-mmap() change
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-3223
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3223
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Yang Yang
>            Assignee: Yang Yang
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> 3179  changes from directly using the bytebuffer from mmap(), to copying that buffer,
> CFS.cacheRow() https://github.com/apache/cassandra/blob/cassandra-1.0.0/src/java/org/apache/cassandra/db/ColumnFamilyStore.java
  line 1126
> says it makes a deep copy exactly to prevent issues from unmmap().
> maybe this deep copy is not needed now given 3179
> if so, maybe slightly better performance in both speed and memory

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message