cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-3146) Minor changes to IntervalTree
Date Wed, 07 Sep 2011 19:03:09 GMT


Hudson commented on CASSANDRA-3146:

Integrated in Cassandra #1084 (See [])
    intervaltree cleanup
patch by Paul Cannon; reviewed by Ben Coverston for CASSANDRA-3146

jbellis :
Files : 
* /cassandra/trunk/src/java/org/apache/cassandra/utils/IntervalTree/
* /cassandra/trunk/src/java/org/apache/cassandra/utils/IntervalTree/

> Minor changes to IntervalTree
> -----------------------------
>                 Key: CASSANDRA-3146
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: paul cannon
>            Assignee: paul cannon
>            Priority: Minor
>             Fix For: 1.0
>         Attachments: 3146.patch.txt
> I have a few minor changes to IntervalTree that I feel improve its performance and readability.
None of this should have an effect on correctness.
> Details:
> * rename IntervalNode members v_left/v_right to intersects_left/intersects_right, to
avoid confusion with the members similarly named "left" and "right"
> * remove the unused IntervalNode.interval member
> * don't calculate the list of intersecting intervals twice in IntervalNode constructor
> * fix comment in IntervalNode constructor: s/i.min/i.max/
> * remove unused java.util.Collections import from
> * remove unused code path (checking twice for null == node) in IntervalTree.searchInternal()
> * genericize Interval parameter type to
> There are still a lot of unchecked operations around the Interval generic stuff, and
the OCD guy inside me wants it to be competely type-safe, but in real life this ought to be
fine like it is. Plus the static Orderings in would need to be made instance
variables and that would just be annoying.
> Ok, so, go ahead and ignore any of this if appropriate. It just helped me feel better
with the code.

This message is automatically generated by JIRA.
For more information on JIRA, see:


View raw message