cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-3087) Leveled compaction allows multiple simultaneous compaction Tasks
Date Wed, 31 Aug 2011 17:18:10 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094705#comment-13094705
] 

Hudson commented on CASSANDRA-3087:
-----------------------------------

Integrated in Cassandra #1061 (See [https://builds.apache.org/job/Cassandra/1061/])
    fix race that allowed multiple simultaneous leveled compaction tasks
patch by jbellis; reviewed by Ben Coverston for CASSANDRA-3087

jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163688
Files : 
* /cassandra/trunk/CHANGES.txt
* /cassandra/trunk/src/java/org/apache/cassandra/db/compaction/CompactionManager.java
* /cassandra/trunk/src/java/org/apache/cassandra/db/compaction/LeveledCompactionStrategy.java
* /cassandra/trunk/src/java/org/apache/cassandra/db/compaction/LeveledCompactionTask.java


> Leveled compaction allows multiple simultaneous compaction Tasks
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-3087
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3087
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 1.0
>
>         Attachments: 3087-v2.txt, 3087.txt
>
>
> CASSANDRA-1608 attempts to restrict itself to one compaction task per CF (see discussion
there for why this is necessary) by synchronizing LCS.getBackgroundTasks but this is not sufficient.
 Consider this sequence of events:
> 1. getBackgroundTasks returns a Task for compacting some L0 sstables.  this Task is scheduled.
> 2. Another SSTable for this CF is flushed, so CompactionManager.submitBackground is called.
 getBT is not currently in-progress so the synchronization does not stop another Task from
being returned and scheduled.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message