cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CASSANDRA-3046) [patch] No need to use .equals on enums, just opens up chance of NPE
Date Wed, 17 Aug 2011 22:01:29 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Ellis resolved CASSANDRA-3046.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0
         Reviewer: jbellis
         Assignee: Dave Brosius

committed, thanks!

> [patch] No need to use .equals on enums, just opens up chance of NPE
> --------------------------------------------------------------------
>
>                 Key: CASSANDRA-3046
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3046
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>            Priority: Trivial
>             Fix For: 1.0
>
>         Attachments: enum_equality.diff
>
>
> pretty trivial patch that change enum1.equals(enum2) into enum1 == enum2, as .equals
isn't needed, and just opens up the possibility of NPEs where == handles them correctly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message