cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-1777) The describe_host API method is misleading in that it returns the interface associated with gossip traffic
Date Wed, 03 Aug 2011 22:21:27 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079076#comment-13079076
] 

Hudson commented on CASSANDRA-1777:
-----------------------------------

Integrated in Cassandra-0.8 #254 (See [https://builds.apache.org/job/Cassandra-0.8/254/])
    describe_ring returns the interface thrift is bound to instead of the
one the storage proto is bound to.
Patch by brandonwilliams, reviewed by jbellis for CASSANDRA-1777

brandonwilliams : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1153683
Files : 
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/gms/VersionedValue.java
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/thrift/CassandraServer.java
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageService.java
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/gms/ApplicationState.java


> The describe_host API method is misleading in that it returns the interface associated
with gossip traffic
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1777
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1777
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Nate McCall
>            Assignee: Brandon Williams
>             Fix For: 1.0
>
>         Attachments: 1777-v2.txt, 1777.txt
>
>   Original Estimate: 16h
>  Remaining Estimate: 16h
>
> If the hardware is configured to use separate interfaces for thrift and gossip, the gossip
interface will be returned, given the results come out of the ReplicationStrategy eventually.
> I understand the approach, but given this is on the API, it effective worthless in situations
of host auto discovery via describe_ring from a client. I actually see this as the primary
use case of this method - why else would I care about the gossip iface from the client perspective?
It's current form should be relegated to JMX only. 
> At the same time, we should add port information as well. 
> describe_splits probably has similar issues.
> I see the potential cart-before-horse issues here and that this will probably be non-trivial
to fix, but I think "give me a set of all the hosts to which I can talk" is pretty important
from a client perspective.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message