Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Thu, 28 Jul 2011 16:11:10 +0000 (UTC)
From: "paul cannon (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: 
 <1800309459.15897.1311869470034.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1980912345.13519.1308272453173.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (CASSANDRA-2785) should export JAVA variable in
 the bin/cassandra and use that in the cassandra-env.sh when check for the
 java version
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CASSANDRA-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

paul cannon updated CASSANDRA-2785:
-----------------------------------

    Attachment: 0002-fix-usage-of-bash-n-tests.patch.txt

Doh, I never knew that one. I normally quote everything, but was trying to match style.

I found a couple other places where we need to quote the argument to test -n.

> should export JAVA variable in the bin/cassandra and use that in the cassandra-env.sh when check for the java version
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-2785
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2785
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jackson Chung
>            Assignee: paul cannon
>         Attachments: 0001-use-JAVA-in-cassandra-env.sh.patch.txt, 0002-fix-usage-of-bash-n-tests.patch.txt
>
>
> I forgot which jira we add this java -version check in the cassandra-env.sh (for adding jamm to the javaagent), but we should probably use the variable JAVA set in bin/cassandra (will need export) and use $JAVA instead of "java" in the cassandra-env.sh
> In a situation where JAVA_HOME may have been properly set as the Sun's java but the PATH still have the OpenJDK's java in front, the check will fail to add the jamm.jar, even though the cassandra jvm is properly started via the Sun's java.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira