Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Tue, 5 Jul 2011 13:38:16 +0000 (UTC)
From: "Nick Bailey (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: 
 <1748237323.623.1309873096545.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1593890346.26005.1308689267499.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (CASSANDRA-2805) Clean up mbeans that return
 Internal Cassandra types
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059901#comment-13059901 ] 

Nick Bailey commented on CASSANDRA-2805:
----------------------------------------

Off the top of my head:

 * A CompactionInfo object is returned when getting compactions from the CompactionManager mbean.
 * Sub-types of Token objects are returned when calling getTokenToEndpointMap (StorageService mbean i think).

I'll see if i can't look around for any more.

> Clean up mbeans that return Internal Cassandra types
> ----------------------------------------------------
>
>                 Key: CASSANDRA-2805
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2805
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8.1
>            Reporter: Nick Bailey
>            Assignee: Nick Bailey
>            Priority: Minor
>             Fix For: 0.8.2
>
>
> We need to clean up wherever we return internal cassandra objects over jmx. Namely CompactionInfo objects as well as Tokens. There may be a few other examples.
> This is bad for two reasons
> 1. You have to load the cassandra jar when querying these mbeans, which sucks.
> 2. Stuff breaks between versions when things are moved. For example, CASSANDRA-1610 moves the compaction related classes around. Any code querying those jmx mbeans in 0.8.0 is now broken in 0.8.2. (assuming those moves stay in the 0.8 branch)
> For things like CompactionInfo we should just expose more mbean methods or serialize to something standard like json.
> I'd like to target this for 0.8.2. Since we've already broken compatibility between 0.8.0 and 0.8.1, I'd say just fix this everywhere now.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira