Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 6 Jul 2011 12:21:16 +0000 (UTC)
From: "Sylvain Lebresne (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: 
 <1535122417.3794.1309954876665.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1705351038.14649.1308314568122.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (CASSANDRA-2786) After a minor compaction,
 deleted key-slices are visible again
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060528#comment-13060528 ] 

Sylvain Lebresne commented on CASSANDRA-2786:
---------------------------------------------

Committed, thanks.

bq. Nit: wouldn't it be cleaner to just pass gcBefore rather than the entire controller to EchoedRow constructor?

I passed the controller because Precompacted and LazilyCompacted do that too, so it felt slightly cleaner, and if we happen to need more info from the controller in the future, it'll be there. But really at the end I did not change it before committing out of laziness :)

> After a minor compaction, deleted key-slices are visible again
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-2786
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2786
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.8.0
>         Environment: Reproduced on single Cassandra node (CentOS 5.5)
> Reproduced on single Cassandra node (Windows Server 2008)
>            Reporter: rene kochen
>            Assignee: Sylvain Lebresne
>             Fix For: 0.8.1, 0.8.2
>
>         Attachments: 0001-Fix-wrong-purge-of-deleted-cf.patch, 2786_part2.patch, CassandraIssue.zip, CassandraIssueJava.zip
>
>
> After a minor compaction, deleted key-slices are visible again.
> Steps to reproduce:
> 1) Insert a row named "test".
> 2) Insert 500000 rows. During this step, row "test" is included in a major compaction:
>    file-1, file-2, file-3 and file-4 compacted to file-5 (includes "test").
> 3) Delete row named "test".
> 4) Insert 500000 rows. During this step, row "test" is included in a minor compaction:
>    file-6, file-7, file-8 and file-9 compacted to file-10 (should include tombstoned "test").
> After step 4, row "test" is live again.
> Test environment:
> Single node with empty database.
> Standard configured super-column-family (I see this behavior with several gc_grace settings (big and small values):
> create column family Customers with column_type = 'Super' and comparator = 'BytesType;
> In Cassandra 0.7.6 I observe the expected behavior, i.e. after step 4, the row is still deleted.
> I've included a .NET program to reproduce the problem. I will add a Java version later on.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira