cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (CASSANDRA-2850) Converting bytes to hex string is unnecessarily slow
Date Fri, 29 Jul 2011 15:38:10 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072867#comment-13072867
] 

Sylvain Lebresne edited comment on CASSANDRA-2850 at 7/29/11 3:37 PM:
----------------------------------------------------------------------

+1, committed, thanks.

I've slightly updated the patch so that we use a copying String constructor in case using
the package-protected one fails. Since it's not part of the public API, it avoids potential
bug with some JDK that wouldn't have this constructor (I'm attaching the committed patch for
the record).

      was (Author: slebresne):
    +1, committed, thanks.

I've slightly updated the patch so that we use a copying String constructor in case using
the package-protected one fails. Since it's not part of the public API, it avoids potential
bug with some JDK that wouldn't have this constructor.
  
> Converting bytes to hex string is unnecessarily slow
> ----------------------------------------------------
>
>                 Key: CASSANDRA-2850
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2850
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: David Allsopp
>            Assignee: David Allsopp
>            Priority: Minor
>             Fix For: 0.8.3
>
>         Attachments: 2850-rebased.txt, 2850-v2.patch, 2850-v4.patch, 2850-v4a.patch,
2850-v5.patch, 2850-v6_08.patch, BytesToHexBenchmark.java, BytesToHexBenchmark2.java, BytesToHexBenchmark3.java,
cassandra-2850a.diff
>
>
> ByteBufferUtil.bytesToHex() is unnecessarily slow - it doesn't pre-size the StringBuilder
(so several re-sizes will be needed behind the scenes) and it makes quite a few method calls
per byte.
> (OK, this may be a premature optimisation, but I couldn't resist, and it's a small change)
> Will attach patch shortly that speeds it up by about x3, plus benchmarking test.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message