cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuki Morishita (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-2920) Remove SSTableWriter.Builder
Date Wed, 20 Jul 2011 15:42:57 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068440#comment-13068440
] 

Yuki Morishita commented on CASSANDRA-2920:
-------------------------------------------

We don't need to check remoteFile.estimatedKeys > 0 in IncomingStreamReader no more, since
CASSANDRA-2916 (maybe put an assert here?).
Also, instead of holding socketChannel, we can just hold socket.

> Remove SSTableWriter.Builder
> ----------------------------
>
>                 Key: CASSANDRA-2920
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2920
>             Project: Cassandra
>          Issue Type: Task
>          Components: Core
>    Affects Versions: 1.0
>            Reporter: Jonathan Ellis
>            Assignee: Stu Hood
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: 2920.txt
>
>
> CASSANDRA-2677 left Builder-oriented streaming in for backwards compatibility, but since
we're going to change the sstable format for 1.0, and Builder doesn't work across format changes,
there's no point in leaving Builder around.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message