Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 997E64B3F for ; Fri, 10 Jun 2011 20:12:21 +0000 (UTC) Received: (qmail 71987 invoked by uid 500); 10 Jun 2011 20:12:21 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 71966 invoked by uid 500); 10 Jun 2011 20:12:21 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 71958 invoked by uid 99); 10 Jun 2011 20:12:21 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jun 2011 20:12:21 +0000 X-ASF-Spam-Status: No, hits=-1996.4 required=5.0 tests=ALL_TRUSTED,FS_REPLICA,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jun 2011 20:12:20 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 466C610D6BD for ; Fri, 10 Jun 2011 20:12:00 +0000 (UTC) Date: Fri, 10 Jun 2011 20:12:00 +0000 (UTC) From: "Jonathan Ellis (JIRA)" To: commits@cassandra.apache.org Message-ID: <696389234.11926.1307736720285.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <715741371.11056.1307722858852.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (CASSANDRA-2759) Scrub could lose increments and replicate that loss MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047422#comment-13047422 ] Jonathan Ellis commented on CASSANDRA-2759: ------------------------------------------- bq. make scrub not skip rows on counter column families +1 bq. CASSANDRA-2614 would change that to 'never ever skipping row' Only if you actually did have a counter in the column_metadata, right? > Scrub could lose increments and replicate that loss > --------------------------------------------------- > > Key: CASSANDRA-2759 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2759 > Project: Cassandra > Issue Type: Bug > Components: Core > Affects Versions: 0.8.0 > Reporter: Sylvain Lebresne > Assignee: Sylvain Lebresne > Labels: counters > Fix For: 0.8.1 > > Attachments: 0001-Renew-nodeId-in-scrub-when-skipping-rows.patch > > > If scrub cannot 'repair' a corrupted row, it will skip it. On node A, if the row contains some sub-count for A id, those will be lost forever since A is the source of truth on it's current id. We should thus renew node A id when that happens to avoid this (not unlike we do in cleanup). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira