Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D985F6C29 for ; Fri, 24 Jun 2011 19:26:08 +0000 (UTC) Received: (qmail 70549 invoked by uid 500); 24 Jun 2011 19:26:08 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 70503 invoked by uid 500); 24 Jun 2011 19:26:08 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 70495 invoked by uid 99); 24 Jun 2011 19:26:08 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jun 2011 19:26:08 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jun 2011 19:26:07 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 6DAC742ED65 for ; Fri, 24 Jun 2011 19:25:47 +0000 (UTC) Date: Fri, 24 Jun 2011 19:25:47 +0000 (UTC) From: "Brandon Williams (JIRA)" To: commits@cassandra.apache.org Message-ID: <329546269.38335.1308943547446.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1485591686.34617.1308864167871.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (CASSANDRA-2818) A 0.8.1 version node can't join the ring made up of 0.8.0 nodes. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-2818: ---------------------------------------- Attachment: 2818.txt In 0.7, we did actually add the node to the endpoint state map by calling addSavedEndpoint. I removed this in CASSANDRA-2092, probably because it makes the log message somewhat incorrect ("XXX has restarted, now UP again") but if it was good enough for 0.7, I think it's good enough for 0.8. Note that even without the disconnect 0.7->0.8 works, but the disconnect is an optimization. Protection from DC/RACK NPEs is guaranteed by addSavedEndpoint initially marking the node as down, so there's no reason to query the state information (other things that utilize getNaturalEndpoints may NPE like nodetool ring, but it's a short window to exploit and non-critical.) Patch to restore the previous behavior to 0.8. > A 0.8.1 version node can't join the ring made up of 0.8.0 nodes. > ---------------------------------------------------------------- > > Key: CASSANDRA-2818 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2818 > Project: Cassandra > Issue Type: Bug > Components: Core > Affects Versions: 0.7.1 > Reporter: Michael Allen > Assignee: Brandon Williams > Fix For: 0.7.7, 0.8.2 > > Attachments: 2818-disconnect.txt, 2818.txt > > > When a 0.8.1 node tries to join a 0.8.0 ring, we see an endless supply of these in system.log: > INFO [Thread-4] 2011-06-23 21:14:04,149 IncomingTcpConnection.java (line 103) Received connection from newer protocol version. Ignorning message. > and the node never joins the ring. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira