Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 473C84A4A for ; Wed, 22 Jun 2011 01:05:09 +0000 (UTC) Received: (qmail 77630 invoked by uid 500); 22 Jun 2011 01:05:09 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 77601 invoked by uid 500); 22 Jun 2011 01:05:09 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 77586 invoked by uid 99); 22 Jun 2011 01:05:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jun 2011 01:05:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jun 2011 01:05:07 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id AFE1F4274B5 for ; Wed, 22 Jun 2011 01:04:47 +0000 (UTC) Date: Wed, 22 Jun 2011 01:04:47 +0000 (UTC) From: "Stu Hood (JIRA)" To: commits@cassandra.apache.org Message-ID: <1960606623.26972.1308704687717.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <15740453.5002.1300223429582.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (CASSANDRA-2336) Extract SSTable.Builder/IndexWriter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052980#comment-13052980 ] Stu Hood commented on CASSANDRA-2336: ------------------------------------- So it looks like the reason this didn't apply cleanly was because it applies atop 2576 and 2629. If those patches look alright, would it be alright if we backed out r1138084 and applied them in that order? I'll confirm that they apply. > Extract SSTable.Builder/IndexWriter > ----------------------------------- > > Key: CASSANDRA-2336 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2336 > Project: Cassandra > Issue Type: Improvement > Components: Core > Reporter: Stu Hood > Assignee: Stu Hood > Priority: Minor > Fix For: 1.0 > > Attachments: 0001-CASSANDRA-2336-Extract-IndexWriter.txt, 0002-CASSANDRA-2336-Extract-Builder.txt, 0003-CASSANDRA-2336-Move-statistics-writing-into-IndexWrite.txt > > > The Builder and IndexWriter classes in SSTableWriter are static, and independently useful. Additionally, we need the ability to subclass them for CASSANDRA-674 and CASSANDRA-2319. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira