Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 25 May 2011 18:21:47 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: 
 <1893289708.42971.1306347707572.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1751903962.27267.1305825287828.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (CASSANDRA-2669) Scrub does not close files
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039263#comment-13039263 ] 

Hudson commented on CASSANDRA-2669:
-----------------------------------

Integrated in Cassandra-0.7 #497 (See [https://builds.apache.org/hudson/job/Cassandra-0.7/497/])
    close scrub file handles
patch by jbellis; reviewed by slebresne for CASSANDRA-2669

jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127589
Files : 
* /cassandra/branches/cassandra-0.7/CHANGES.txt
* /cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/db/CompactionManager.java


> Scrub does not close files
> --------------------------
>
>                 Key: CASSANDRA-2669
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2669
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 0.7.3
>            Reporter: Daniel Doubleday
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7.7, 0.8.1
>
>         Attachments: 2669.txt
>
>
> After scrubbing I find that cassandra process still holds file handles to the deleted sstables:
> {noformat}
> root@blnrzh047:/mnt/cassandra# jps
> 6932 Jps
> 32359 CassandraDaemon
> 32398 CassandraJmxHttpServer
> root@blnrzh047:/mnt/cassandra# du -sh .
> 315G	.
> root@blnrzh047:/mnt/cassandra# df -h .
> Filesystem            Size  Used Avail Use% Mounted on
> /dev/md0              1.1T  626G  420G  60% /mnt/cassandra
> root@blnrzh047:/mnt/cassandra# lsof | grep /mnt
> java      32359        root  356r      REG                9,0           24    4194599 /mnt/cassandra/data/system/Migrations-f-13-Index.db (deleted)
> java      32359        root  357r      REG                9,0       329451    4194547 /mnt/cassandra/data/system/HintsColumnFamily-f-588-Data.db (deleted)
> java      32359        root  358r      REG                9,0           22    4194546 /mnt/cassandra/data/system/HintsColumnFamily-f-588-Index.db (deleted)
> java      32359        root  359r      REG                9,0       313225    4194534 /mnt/cassandra/data/system/HintsColumnFamily-f-587-Data.db (deleted)
> java      32359        root  360r      REG                9,0           22    4194494 /mnt/cassandra/data/system/HintsColumnFamily-f-587-Index.db (deleted)
> java      32359        root  361r      REG                9,0        30452    4194636 /mnt/cassandra/data/system/Schema-f-13-Data.db (deleted)
> java      32359        root  362r      REG                9,0          484    4194635 /mnt/cassandra/data/system/Schema-f-13-Index.db (deleted)
> {noformat}
> I guess there's a missing dataFile.close() in CompactionManager:648

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira