Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6C9DB510A for ; Thu, 12 May 2011 20:31:29 +0000 (UTC) Received: (qmail 93227 invoked by uid 500); 12 May 2011 20:31:29 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 93204 invoked by uid 500); 12 May 2011 20:31:29 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 93196 invoked by uid 99); 12 May 2011 20:31:29 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 May 2011 20:31:29 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 May 2011 20:31:27 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 490D1870E4 for ; Thu, 12 May 2011 20:30:47 +0000 (UTC) Date: Thu, 12 May 2011 20:30:47 +0000 (UTC) From: "Stu Hood (JIRA)" To: commits@cassandra.apache.org Message-ID: <1203629132.8069.1305232247280.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <793994711.5936.1305175667284.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (CASSANDRA-2641) AbstractBounds.normalize should deal with overlapping ranges MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CASSANDRA-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032652#comment-13032652 ] Stu Hood commented on CASSANDRA-2641: ------------------------------------- bq. merge intersecting ranges (it makes sense a "normalize" function would do that and it's fairly trivial) Famous last words =) > AbstractBounds.normalize should deal with overlapping ranges > ------------------------------------------------------------ > > Key: CASSANDRA-2641 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2641 > Project: Cassandra > Issue Type: Test > Components: Core > Reporter: Stu Hood > Assignee: Stu Hood > Priority: Minor > Fix For: 1.0 > > > Apparently no consumers have encountered it in production, but AbstractBounds.normalize does not handle overlapping ranges. If given overlapping ranges, the output will be sorted but still overlapping, for which SSTableReader.getPositionsForRanges will choose ranges in an SSTable that may overlap. > We should either add an assert in normalize(), or in getPositionsForRanges() to ensure that this never bites us in production. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira