cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-2694) remove references to DatabaseDescriptor in CFMetaData
Date Tue, 24 May 2011 01:51:53 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038356#comment-13038356
] 

Jonathan Ellis commented on CASSANDRA-2694:
-------------------------------------------

I think it would be cleaner if JDBC just accepted the CfDef as given by the server. It would
be weird if we changed the validation code in a newer version, causing the JDBC code when
run against an old server to say "that can't be right!"

I'd move the validate code to ThriftValidation with the rest of the "is this struct I got
from the user reasonable" checks, and have the fromThrift calls in CassandraServer call that
method manually, so that fromThrift just does what it advertises.

> remove references to DatabaseDescriptor in CFMetaData
> -----------------------------------------------------
>
>                 Key: CASSANDRA-2694
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2694
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.8.0 beta 2
>            Reporter: Aaron Morton
>            Assignee: Aaron Morton
>            Priority: Minor
>             Fix For: 0.8.0
>
>         Attachments: 0001-2694.patch
>
>
> The JDBC driver uses CFMetaData.fromThrift(), it was calling validateMemtableSettings()
which used static methods on  DatabaseDescriptor. This causes cassandra.yaml to be loaded
and means the client side needs access to the file. 
> I think this needs to be fixed for 0.8, I have the patch. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message