cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-2659) Improve forceDeserialize/getCompactedRow encapsulation
Date Tue, 17 May 2011 11:03:47 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034708#comment-13034708
] 

Sylvain Lebresne commented on CASSANDRA-2659:
---------------------------------------------

nitpicks:
  * the could remove the descriptor argument of the first getCompactedRow() and call needDeserialize()
for the EchoedRow case.
  * we could use that first getCompactedRow() in SSTableWriter (it's really only cosmetic
as we forceDesialize)
  * the comment of that first getCompactedRow() method is not completely correct, since the
method may purge data (either if the sstable is of an old format or if forceDeserialize is
set) while the comment suggest it never does it.

but those are nitpicks, so with or without +1

> Improve forceDeserialize/getCompactedRow encapsulation
> ------------------------------------------------------
>
>                 Key: CASSANDRA-2659
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2659
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.8.1
>
>         Attachments: 2659.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message