cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicholas Telford (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CASSANDRA-2693) Renaming/Dropping Keyspace shouldn't touch hints
Date Mon, 23 May 2011 19:08:47 GMT
Renaming/Dropping Keyspace shouldn't touch hints
------------------------------------------------

                 Key: CASSANDRA-2693
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2693
             Project: Cassandra
          Issue Type: Improvement
          Components: Core
            Reporter: Nicholas Telford
            Priority: Trivial


Currently, when renaming or dropping a keyspace, HintedHandoffManager.renameHints() is called
to drop and re-insert every hint for that keyspace with the new keyspace name.

This code appears to have been written for a different HintsCF schema, as it drops the row
named by the old keyspace name and re-creates all of it's columns under the key of the new
keyspace name. This is not the current HintsCF schema. It seems the impact of this is that
it doesn't do anything (beyond a pointless index scan for the HintsCF) as the keys will never
exist.

It looks safe to remove this code entirely and let the hints simply become invalid. When they're
replayed invalid hints are silently dropped, which seems like the best option.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message