Return-Path: Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: (qmail 91080 invoked from network); 5 Apr 2011 21:31:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 5 Apr 2011 21:31:45 -0000 Received: (qmail 61149 invoked by uid 500); 5 Apr 2011 21:31:45 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 61122 invoked by uid 500); 5 Apr 2011 21:31:45 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 61114 invoked by uid 99); 5 Apr 2011 21:31:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2011 21:31:45 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2011 21:31:43 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id B789F941A5 for ; Tue, 5 Apr 2011 21:31:05 +0000 (UTC) Date: Tue, 5 Apr 2011 21:31:05 +0000 (UTC) From: "Jonathan Ellis (JIRA)" To: commits@cassandra.apache.org Message-ID: <99877186.36021.1302039065748.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <985022143.35908.1302036665806.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (CASSANDRA-2419) Risk of counter over-count when recovering commit log MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CASSANDRA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016131#comment-13016131 ] Jonathan Ellis commented on CASSANDRA-2419: ------------------------------------------- to be clear: i believe if we do this we can drop CL header construct entirely. instead, on startup we read last N bytes of each sstable file to get start-reply-at positions -- position for commitlog X and CF Y is max(start position) for sstables in X who were flushed during Y's tenure. > Risk of counter over-count when recovering commit log > ----------------------------------------------------- > > Key: CASSANDRA-2419 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2419 > Project: Cassandra > Issue Type: Bug > Components: Core > Affects Versions: 0.8 > Reporter: Sylvain Lebresne > Assignee: Sylvain Lebresne > Labels: counters > Original Estimate: 8h > Remaining Estimate: 8h > > When a memtable was flush, there is a small delay before the commit log replay position gets updated. If the node fails during this delay, all the updates of this memtable will be replay during commit log recovery and will end-up being over-counts. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira