Return-Path: Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: (qmail 26701 invoked from network); 5 Apr 2011 22:42:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 5 Apr 2011 22:42:45 -0000 Received: (qmail 58603 invoked by uid 500); 5 Apr 2011 22:42:45 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 58576 invoked by uid 500); 5 Apr 2011 22:42:45 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 58568 invoked by uid 99); 5 Apr 2011 22:42:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2011 22:42:45 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2011 22:42:43 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id BF95994764 for ; Tue, 5 Apr 2011 22:42:05 +0000 (UTC) Date: Tue, 5 Apr 2011 22:42:05 +0000 (UTC) From: "Jonathan Ellis (JIRA)" To: commits@cassandra.apache.org Message-ID: <521125464.36302.1302043325781.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <2119605374.10888.1301046665919.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (CASSANDRA-2384) Merge Mutation and CounterMutation thrift structure MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CASSANDRA-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016162#comment-13016162 ] Jonathan Ellis commented on CASSANDRA-2384: ------------------------------------------- Do we need to update TV.validateDeletion to require the timestamp for non-commutative ops now that Thrift isn't enforcing that for us? > Merge Mutation and CounterMutation thrift structure > --------------------------------------------------- > > Key: CASSANDRA-2384 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2384 > Project: Cassandra > Issue Type: Improvement > Components: API > Affects Versions: 0.8 > Reporter: Sylvain Lebresne > Assignee: Sylvain Lebresne > Fix For: 0.8 > > Attachments: 0001-Make-thrift-changes-v2.patch, 0001-Make-thrift-changes-v3.patch, 0001-Make-thrift-changes.patch, 0002-Merge-CounterMutation-and-Mutation-v2.patch, 0002-Merge-CounterMutation-and-Mutation-v3.patch, 0002-Merge-CounterMutation-and-Mutation.patch, 0003-Update-o.a.c.stress.Stress-for-batch_mutate.txt > > Original Estimate: 2h > Remaining Estimate: 2h > > Standard and counter mutation are in 2 different structures, which prevents from doing a standard and counter mutation in the same batch_mutate (you have to use batch_add for counters). It's probably a good idea to merge CounterMutation and Mutation (and simply remove batch_add) to lift that limitation. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira