Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 713F11BC9 for ; Sat, 23 Apr 2011 01:28:47 +0000 (UTC) Received: (qmail 7499 invoked by uid 500); 23 Apr 2011 01:28:47 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 7480 invoked by uid 500); 23 Apr 2011 01:28:47 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 7472 invoked by uid 99); 23 Apr 2011 01:28:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Apr 2011 01:28:47 +0000 X-ASF-Spam-Status: No, hits=-1996.4 required=5.0 tests=ALL_TRUSTED,FS_REPLICA,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Apr 2011 01:28:44 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id CF52DAE38D for ; Sat, 23 Apr 2011 01:28:05 +0000 (UTC) Date: Sat, 23 Apr 2011 01:28:05 +0000 (UTC) From: "Hudson (JIRA)" To: commits@cassandra.apache.org Message-ID: <2088372882.77763.1303522085846.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <2025035407.72497.1303349825727.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (CASSANDRA-2525) CQL: create keyspace does not the replication factor argument and allows invalid sql to pass thru MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CASSANDRA-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023479#comment-13023479 ] Hudson commented on CASSANDRA-2525: ----------------------------------- Integrated in Cassandra-0.8 #36 (See [https://builds.apache.org/hudson/job/Cassandra-0.8/36/]) validate CQL create keyspace options patch by jbellis; reviewed by eevans for CASSANDRA-2525 > CQL: create keyspace does not the replication factor argument and allows invalid sql to pass thru > ------------------------------------------------------------------------------------------------- > > Key: CASSANDRA-2525 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2525 > Project: Cassandra > Issue Type: Bug > Affects Versions: 0.8 beta 1 > Environment: Cluster: 3 node Rackspace cluster running Centos 5.5. > Build: https://builds.apache.org/hudson/job/Cassandra/859/artifact/cassandra/build/apache-cassandra-2011-04-20_10-01-29-bin.tar.gz > Reporter: Cathy Daw > Assignee: Jonathan Ellis > Priority: Critical > Labels: cql > Fix For: 0.8.0 > > Attachments: 2525.txt > > > I ran the following SQL in cqlsh and immediately received a socket closed error. After that point, I couldn't run nodetool, and then got an exception starting up the cluster. > Please Note: The following syntax is valid in 0.74 but invalid in 0.8. > The 0.8 cassandra-cli errors on the following statement, so the resolution of the bug is to have cqlsh block this incorrect syntax. > {code} > create keyspace testcli with replication_factor=1 > and placement_strategy = 'org.apache.cassandra.locator.SimpleStrategy'; > {code} > {code} > CREATE KEYSPACE testcql with replication_factor = 1 and strategy_class = 'org.apache.cassandra.locator.SimpleStrategy'; > {code} > {code} > ERROR 01:29:26,989 Exception encountered during startup. > java.lang.RuntimeException: org.apache.cassandra.config.ConfigurationException: SimpleStrategy requires a replication_factor strategy option. > at org.apache.cassandra.db.Table.(Table.java:278) > at org.apache.cassandra.db.Table.open(Table.java:110) > at org.apache.cassandra.service.AbstractCassandraDaemon.setup(AbstractCassandraDaemon.java:160) > at org.apache.cassandra.service.AbstractCassandraDaemon.activate(AbstractCassandraDaemon.java:314) > at org.apache.cassandra.thrift.CassandraDaemon.main(CassandraDaemon.java:80) > Caused by: org.apache.cassandra.config.ConfigurationException: SimpleStrategy requires a replication_factor strategy option. > at org.apache.cassandra.locator.SimpleStrategy.validateOptions(SimpleStrategy.java:79) > at org.apache.cassandra.locator.AbstractReplicationStrategy.createReplicationStrategy(AbstractReplicationStrategy.java:262) > at org.apache.cassandra.db.Table.createReplicationStrategy(Table.java:328) > at org.apache.cassandra.db.Table.(Table.java:274) > ... 4 more > Exception encountered during startup. > java.lang.RuntimeException: org.apache.cassandra.config.ConfigurationException: SimpleStrategy requires a replication_factor strategy option. > at org.apache.cassandra.db.Table.(Table.java:278) > at org.apache.cassandra.db.Table.open(Table.java:110) > at org.apache.cassandra.service.AbstractCassandraDaemon.setup(AbstractCassandraDaemon.java:160) > at org.apache.cassandra.service.AbstractCassandraDaemon.activate(AbstractCassandraDaemon.java:314) > at org.apache.cassandra.thrift.CassandraDaemon.main(CassandraDaemon.java:80) > Caused by: org.apache.cassandra.config.ConfigurationException: SimpleStrategy requires a replication_factor strategy option. > at org.apache.cassandra.locator.SimpleStrategy.validateOptions(SimpleStrategy.java:79) > at org.apache.cassandra.locator.AbstractReplicationStrategy.createReplicationStrategy(AbstractReplicationStrategy.java:262) > at org.apache.cassandra.db.Table.createReplicationStrategy(Table.java:328) > at org.apache.cassandra.db.Table.(Table.java:274) > ... 4 more > {code} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira