Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2F7F63D40 for ; Thu, 28 Apr 2011 08:48:42 +0000 (UTC) Received: (qmail 64591 invoked by uid 500); 28 Apr 2011 08:48:42 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 64564 invoked by uid 500); 28 Apr 2011 08:48:42 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 64556 invoked by uid 99); 28 Apr 2011 08:48:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Apr 2011 08:48:42 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Apr 2011 08:48:40 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 3CD3BB77FF for ; Thu, 28 Apr 2011 08:48:03 +0000 (UTC) Date: Thu, 28 Apr 2011 08:48:03 +0000 (UTC) From: "Stu Hood (JIRA)" To: commits@cassandra.apache.org Message-ID: <1821229857.8463.1303980483245.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1373397877.79268.1303694525842.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (CASSANDRA-2552) ReadResponseResolver Race MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stu Hood updated CASSANDRA-2552: -------------------------------- Reviewer: stuhood Assignee: Jonathan Ellis (was: Stu Hood) > ReadResponseResolver Race > ------------------------- > > Key: CASSANDRA-2552 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2552 > Project: Cassandra > Issue Type: Bug > Components: Core > Affects Versions: 0.7.1 > Reporter: Stu Hood > Assignee: Jonathan Ellis > Fix For: 0.7.6 > > Attachments: 0001-Move-Resolvers-to-atomic-append-count.txt, 2552-v2-07.txt, 2552-v2.txt, ResolveRaceTest.java > > > When receiving a response, ReadResponseResolver uses a 3 step process to decide whether to trigger the condition that enough responses have arrived: > # Add new response > # Check response set size > # Check that data is present > I think that these steps must have been reordered by the compiler in some cases, because I was able to reproduce a case for a QUORUM read where the condition is not properly triggered: > {noformat} > INFO [RequestResponseStage:15] 2011-04-25 00:26:53,514 ReadResponseResolver.java (line 87) post append for 1087367065: hasData=false in 2 messages > INFO [RequestResponseStage:8] 2011-04-25 00:26:53,514 ReadResponseResolver.java (line 87) post append for 1087367065: hasData=true in 1 messages > INFO [pool-1-thread-54] 2011-04-25 00:27:03,516 StorageProxy.java (line 623) Read timeout: java.util.concurrent.TimeoutException: ReadResponseResolver@1087367065(/10.34.131.109=false,/10.34.132.122=true,) > {noformat} > The last line shows that both results were present, and that one of them was holding data. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira