Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 13 Apr 2011 17:17:05 +0000 (UTC)
From: "Sylvain Lebresne (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: 
 <1596788611.55570.1302715025760.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1858062058.52197.1302613925842.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Issue Comment Edited] (CASSANDRA-2460) Make scrub validate
 deserialized columns
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019268#comment-13019268 ] 

Sylvain Lebresne edited comment on CASSANDRA-2460 at 4/13/11 5:16 PM:
----------------------------------------------------------------------

Attaching patch against 0.7 branch to validate as much of the column fields I can think of during scrub.

Note that I didn't do it but it may be worth merging the forceDeserialization and validateColumns for {Pre|Lazy}CompactedRow.

The 0.8 patch will probably be a little bit different, first because it may be cleaner to move the validation in CompactionController and because we will need to handle correctly CounterColumns. I'll write the patch separately when I have some feedback on this one.

      was (Author: slebresne):
    Attaching patch against 0.7 branch to validate as much of the column fields I can think of during scrub.

Note that I didn't do it but it may be worst merging the forceDeserialization and validateColumns for {Pre|Lazy}CompactedRow.

The 0.8 patch will probably be a little bit different, first because it may be cleaner to move the validation in CompactionController and because we will need to handle correctly CounterColumns. I'll write the patch separately when I have some feedback on this one.
  
> Make scrub validate deserialized columns
> ----------------------------------------
>
>                 Key: CASSANDRA-2460
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2460
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 0.7.5
>
>         Attachments: 0001-Make-scrub-check-column-fields.patch
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Right now, scrub deserialize the columns but don't validate the fields, and such there is a number of errors it could fix (or at least corrupted rows it could skip) but don't.
> This ticket proposes to handle those errors.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira