Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 20 Apr 2011 01:13:05 +0000 (UTC)
From: "Jackson Chung (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: 
 <1111822126.68805.1303261985777.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <263759700.65476.1303159145849.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Issue Comment Edited] (CASSANDRA-2499) cassandra-env.sh
 pattern matching for OpenJDK broken in some cases
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021889#comment-13021889 ] 

Jackson Chung edited comment on CASSANDRA-2499 at 4/20/11 1:11 AM:
-------------------------------------------------------------------

chances are the default /bin/sh is linked to dash, please run a ls -al /bin/sh to confirm

a minor fix could be remove the [[ and add "" around the variables and values.

-if [[ $java_version != \*OpenJDK\* ]]
+if [ "$java_version" != "\*OpenJDK\*" ]

a more drastic fix is to update all the /bin/sh with /bin/bash (if desired to only support on bash)

see ref: https://wiki.ubuntu.com/DashAsBinSh

suggest to be reviewed to make a decision.

      was (Author: cywjackson):
    chances are the default /bin/sh is linked to dash, please run a ls -al /bin/sh to confirm

a minor fix could be remove the [[ and add "" around the variables and values.

-if [[ $java_version != *OpenJDK* ]]
+if [ "$java_version" != "*OpenJDK*" ]

a more drastic fix is to update all the /bin/sh with /bin/bash (if desired to only support on bash)

see ref: https://wiki.ubuntu.com/DashAsBinSh

suggest to be reviewed to make a decision.
  
> cassandra-env.sh pattern matching for OpenJDK broken in some cases
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-2499
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2499
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.8
>            Reporter: Tyler Hobbs
>            Assignee: Eric Evans
>             Fix For: 0.8
>
>
> With bash version 4.1.5, the section of cassandra-env that tries to match the JDK distribution seems to have some kind of syntax error.  I get the following message when running bin/cassandra:
> {noformat}
> bin/../conf/cassandra-env.sh: 99: [[: not found
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira