cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-2167) Add a deserialize(ByteBuffer) method to ColumnFamilySerializer
Date Mon, 11 Apr 2011 17:43:05 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018453#comment-13018453
] 

Jonathan Ellis commented on CASSANDRA-2167:
-------------------------------------------

Revisiting this, I don't think it's actually a valid optimization -- if we free the backing
Memory object before shipping the read buffers off over the network, we'll segfault. No?

> Add a deserialize(ByteBuffer) method to ColumnFamilySerializer
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-2167
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2167
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>    Affects Versions: 0.8
>            Reporter: Vijay
>            Assignee: Vijay
>            Priority: Minor
>             Fix For: 0.8
>
>         Attachments: 0001-Reduce-Byte-Copy-Streams.txt, 0002-Reduce-Byte-Copy-BBUtil.txt,
0003-Reduce-BB-Copy.txt
>
>
> by adding deserialize bytebuffer in the columnFamilySerializer we might be able to avoid
copying of the bytes[] while deserializing the CF.
> This can be done using....
>         ByteBuffer buff = ByteBuffer.wrap(bb.array(), bb.position(), length);
> This is an improvement on "https://issues.apache.org/jira/browse/CASSANDRA-1969" Plz
see jonathan's comment.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message