Return-Path: Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: (qmail 38481 invoked from network); 9 Mar 2011 19:54:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 9 Mar 2011 19:54:23 -0000 Received: (qmail 69246 invoked by uid 500); 9 Mar 2011 19:54:23 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 69231 invoked by uid 500); 9 Mar 2011 19:54:23 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 69223 invoked by uid 99); 9 Mar 2011 19:54:23 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Mar 2011 19:54:23 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Mar 2011 19:54:21 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 6B2A83A132D for ; Wed, 9 Mar 2011 19:53:59 +0000 (UTC) Date: Wed, 9 Mar 2011 19:53:59 +0000 (UTC) From: "Jonathan Ellis (JIRA)" To: commits@cassandra.apache.org Message-ID: <2029765719.8923.1299700439435.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1539774986.8910.1299700079769.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] Updated: (CASSANDRA-2301) OOM on repair with many inconsistent ranges MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CASSANDRA-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-2301: -------------------------------------- Reviewer: jbellis Description: Repair can OOM when lots of ranges are inconsistent, causing many sstables to be streamed. I replicated the error by making 1264 3MB sstables on one node, added a second node, changed the replication factor to 2, and ran a repair. Looking at the heap dump of the original failure, there were 2.4GB of FutureTasks, each taking up 8MB of space. I tracked down the BufferedRandomAccessFile and made sure that it was cleared every time it was closed inside of src/java/org/apache/cassandra/io/sstable/SSTableWriter.java. Attached is the patch I used which stopped the error when I was trying to replicate it. was: On repair, the java heap space tends to OOM. I replicated the error by making 1264 3MB sstables on one node, added a second node, changed the replication factor to 2, and ran a repair. Looking at the heap dump of the original failure, there were 2.4GB of FutureTasks, each taking up 8MB of space. I tracked down the BufferedRandomAccessFile and made sure that it was cleared every time it was closed inside of src/java/org/apache/cassandra/io/sstable/SSTableWriter.java. Attached is the patch I used which stopped the error when I was trying to replicate it. Affects Version/s: (was: 0.7.1) 0.7.0 Assignee: Joaquin Casares Summary: OOM on repair with many inconsistent ranges (was: OOM on repair) > OOM on repair with many inconsistent ranges > ------------------------------------------- > > Key: CASSANDRA-2301 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2301 > Project: Cassandra > Issue Type: Bug > Affects Versions: 0.7.0 > Reporter: Joaquin Casares > Assignee: Joaquin Casares > Fix For: 0.7.4 > > Attachments: 2301.diff > > > Repair can OOM when lots of ranges are inconsistent, causing many sstables to be streamed. > I replicated the error by making 1264 3MB sstables on one node, added a second node, changed the replication factor to 2, and ran a repair. > Looking at the heap dump of the original failure, there were 2.4GB of FutureTasks, each taking up 8MB of space. I tracked down the BufferedRandomAccessFile and made sure that it was cleared every time it was closed inside of src/java/org/apache/cassandra/io/sstable/SSTableWriter.java. > Attached is the patch I used which stopped the error when I was trying to replicate it. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira