Return-Path: Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: (qmail 53562 invoked from network); 14 Mar 2011 22:39:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 14 Mar 2011 22:39:51 -0000 Received: (qmail 20481 invoked by uid 500); 14 Mar 2011 22:39:51 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 20438 invoked by uid 500); 14 Mar 2011 22:39:51 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 20256 invoked by uid 99); 14 Mar 2011 22:39:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Mar 2011 22:39:51 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Mar 2011 22:39:50 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id E25673A9CEF for ; Mon, 14 Mar 2011 22:39:29 +0000 (UTC) Date: Mon, 14 Mar 2011 22:39:29 +0000 (UTC) From: "Matthew F. Dennis (JIRA)" To: commits@cassandra.apache.org Message-ID: <1895360782.2300.1300142369923.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <432035348.14496.1299255457215.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] Commented: (CASSANDRA-2272) Refactor Key and Row caches handling code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006686#comment-13006686 ] Matthew F. Dennis commented on CASSANDRA-2272: ---------------------------------------------- can you rebase on trunk please? > Refactor Key and Row caches handling code > ------------------------------------------ > > Key: CASSANDRA-2272 > URL: https://issues.apache.org/jira/browse/CASSANDRA-2272 > Project: Cassandra > Issue Type: Improvement > Reporter: Sylvain Lebresne > Assignee: Sylvain Lebresne > Priority: Minor > Fix For: 0.8 > > Attachments: 0001-Refactor-key-and-row-cache-handling-code-v2.patch, 0001-Refactor-key-and-row-cache-handling-code.patch > > Original Estimate: 4h > Remaining Estimate: 4h > > The code related to key and row caches has a bunch of code duplication. It's > moreover a bit scattered, the caches are in SSTableTracker but the scheduled > task to save them are in CFStore. And having the caches in SSTableTracker is > not very logic, for row cache at least, since it does not only concern the > sstables. Proposed patch refactor this to avoid the duplication and put all > the cache handling code in one place. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira