cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-2262) use o.a.c.marshal.*Type for CQL
Date Thu, 03 Mar 2011 21:46:36 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002258#comment-13002258
] 

Sylvain Lebresne commented on CASSANDRA-2262:
---------------------------------------------

bq. Can you elaborate?

I mean that the ticket description said that we should have get(from(s)) == s, but some of
the test in RoundTripTest actually test from(get(b)) == b (all of them except for the two
UUID tests). So this is not really testing what it should. And this is not the same since
for instance, get(from(s)) always work for IntegerType while from(get(b)) can throw an exception
(and thus not work) depending on what is b as shown by testInteger2.

> use o.a.c.marshal.*Type for CQL 
> --------------------------------
>
>                 Key: CASSANDRA-2262
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2262
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: API
>    Affects Versions: 0.8
>            Reporter: Eric Evans
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.8
>
>         Attachments: v1-0001-test-shows-no-roundtrip-in-BytesType.txt, v1-0002-BytesType.fromString-expects-a-hex-string.txt,
v1-0003-compose-method-for-AbstractTypes.txt, v1-0004-assume-utf8-in-CliTest-keys-dammit.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Presently, {{o.a.c.cql.Term.getByteBuffer}} manage's the conversion from a parsed term
to a {{ByteBuffer}} of the right contents, this should be moved into the individual {{AbstractType}}
subclasses (aka {{AbstractType.fromString}}).
> Additionally, a method that does the inverse (returning the string equivalent), needs
to exists such that {{AbstractType.getString(AbstractType.fromString(s)) == s}}
> Finally, for use in results decoding a method should exist that given a {{ByteBuffer}}
will return the appropriate object for that type.  For example, {{IntegerType.compose(ByteBuffer)
-> java.math.BigInteger}}, or {{LexicalUUIDType.compose(ByteBuffer) -> java.util.UUID}}.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message